pr revisit expected failed kotl tests plus updates#921
Open
Conversation
* kotl/kotl-mode.el (kotl-mode:kill-tree): Move to valid position
first when inital cell is created.
* test/kotl-mode-tests.el (kotl-mode--kill-tree-first-and-only-tree):
Verify change works.
* kotl/kotl-mode.el (kotl-mode:erase-buffer): Add
kotl-mode:erase-buffer to make it easier to reuse buffers in tests.
* test/kotl-mode-tests.el (kotl-mode--erase-buffer): Add test for new
function.
* test/kotl-mode-tests.el (kotl-mode-split-cell): Remove
expected-result failed but add FIXME comment where
kotl-mode:split-cell fails.
Use kotl-mode:erase-buffer for clearer reuse of test buffer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
This PR changed addresses the one remaining test in the suite where we
have expected failed. There is a problem with kotl-mode:split-cell
that introduces an extra empty line in a case. We have not attempted
to fix that for a long time so I document the problem with a FIXME
comment and change the verification so that the test succeeds.
While working on the test I noticed an issue with kotl-mode:kill-tree
that is fixed here with a test case.
I also added a new function, kotl-mode:erase-buffer, plus a test case
for it. I think it makes writing test cases easier when we can erase a
buffer to start all over again. A pattern we have started to use more
of.
The PR is split in multiple commits for easier review.